Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #3640

Merged
merged 1 commit into from
Jan 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/components/NcActions/NcActions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ export default {
* The render function to display the component
*
* @param {Function} h The function to create VNodes
* @return {VNodes} The created VNodes
* @return {object|undefined} The created VNode
*/
render(h) {
/**
Expand Down Expand Up @@ -922,7 +922,7 @@ export default {
/**
* Render the provided action
*
* @param {VNode} action the action to render
* @param {object} action the action to render
* @return {Function} the vue render function
*/
const renderInlineAction = (action) => {
Expand Down Expand Up @@ -980,7 +980,7 @@ export default {
/**
* Render the actions popover
*
* @param {VNode} actions the actions to render within
* @param {Array} actions the actions to render within
* @return {Function} the vue render function
*/
const renderActionsPopover = (actions) => {
Expand Down Expand Up @@ -1132,7 +1132,8 @@ export default {
},
[
renderActionsPopover(actions),
])
]
)
},
}
</script>
Expand Down
3 changes: 3 additions & 0 deletions src/components/NcAppNavigationItem/NcAppNavigationItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -716,6 +716,9 @@ export default {

/**
* Is this an external link
*
* @param {string} href The link to check
* @return {boolean} Whether it is external or not
*/
isExternal(href) {
// Match any protocol
Expand Down
1 change: 1 addition & 0 deletions src/components/NcBreadcrumb/NcBreadcrumb.vue
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ export default {
}
/**
* Event emitted when something is dropped on the breadcrumb.
*
* @param {Event} event The DOM drop event
* @param {(string|object)} to The `to` prop or, if not set, the `href` prop
*/
Expand Down
3 changes: 2 additions & 1 deletion src/components/NcBreadcrumbs/NcBreadcrumbs.vue
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ export default {
* The render function to display the component
*
* @param {Function} h The function to create VNodes
* @return {VNodes} The created VNodes
* @return {object|undefined} The created VNode
*/
render(h) {
// Get the breadcrumbs
Expand All @@ -482,6 +482,7 @@ export default {
}

// Add the root icon to the first breadcrumb
// eslint-disable-next-line import/no-named-as-default-member
Vue.set(breadcrumbs[0].componentOptions.propsData, 'icon', this.rootIcon)

// The array of all created VNodes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ export default {
/**
* Returns the proper Material icon depending on the select case
*
* @return {Component}
* @return {object}
*/
checkboxRadioIconElement() {
if (this.type === TYPE_RADIO) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ export default {
* Returns Object with string values of a Date
*
* @param {Date} value The selected value
* @return {object}
* @return {object|undefined}
*/
getReadableDate(value) {
if (value instanceof Date) {
Expand All @@ -331,7 +331,7 @@ export default {
* Returns preformatted value for the input field
*
* @param {Date} value The selected value
* @return {string}
* @return {string|undefined}
*/
formatValue(value) {
if (value instanceof Date) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcHighlight/NcHighlight.vue
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export default {
* The render function to display the component
*
* @param {Function} h The function to create VNodes
* @return {VNodes} The created VNodes
* @return {object} The created VNode
*/
render(h) {
if (!this.ranges.length) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ let initialized = false
* Gets the timezone-manager
* initializes it if necessary
*
* @return {TimezoneManager}
* @return {object}
*/
export default function() {
if (!initialized) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcVNodes/NcVNodes.vue
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default {
*
* @param {Function} h The function to create VNodes
* @param {object} context The context object of the functional component
* @return {VNodes} The created VNodes
* @return {object} The created VNode
*/
render(h, context) {
return context.props.vnodes
Expand Down
4 changes: 2 additions & 2 deletions src/utils/GetParent.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
/**
* Get the first parent component matching the provided name
*
* @param {object} context the context to search from (usualy this)
* @param {object} context the context to search from (usually this)
* @param {string} name the parent name
* @return {object} the parent component
* @return {object|undefined} the parent component
*/
const GetParent = function(context, name) {
let parent = context.$parent
Expand Down