Fix setting trailingButtonLabel for PasswordField #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
requested review from
marcoambrosini,
skjnldsv,
Pytal and
CarlSchwan
raimund-schluessler
added
bug
Pytal
approved these changes
Feb 1, 2023
artonge
approved these changes
Feb 2, 2023
This was referenced Feb 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes setting the
trailingButtonLabel(which is thearia-labelof the trailing button in theNcInputFieldcomponent) from theNcPasswordFieldso that the password toggle button gets the correct label.This also fixes the
You need to fill either the text or the ariaLabel props in the button component.warning currently visible in the docs when looking at theNcPasswordFieldcomponent.