Use proper default actions aria label in NcListItem

[raimund-schluessler]

We currently overwrite the aria-label of the NcActions component used in the NcListItem component with an empty string, which leads to a You need to fill either the text or the ariaLabel props in the button component. triggered by NcListItem by default. This PR sets the default aria-label in NcListItem to the same value as used in NcActions.

[artonge]

I think this is on purpose for accessibility to not have multiple actions with the same aria label

[raimund-schluessler]

I think this is on purpose for accessibility to not have multiple actions with the same aria label

Well, every action has this label unless you overwrite it explicitly. So there are multiple actions with this label on the same page already. Not sure what's the benefit of setting an empty aria-label for some actions, but not all (besides triggering a warning about it 🙈).

[artonge]

Not sure what's the benefit of setting an empty aria-label for some actions, but not all (besides triggering a warning about it see_no_evil).

Then the fix would be to remove the default aria-label on the actions that have a one, no ?
Maybe @Pytal or @JuliaKirschenheuter that are working on accessibility can give us their insights ?

[raimund-schluessler]

Then the fix would be to remove the default aria-label on the actions that have a one ?

That would mean making the aria-label prop required, otherwise the NcButton component will complain about every actions component used. That would be a breaking change. And I think devs would then just end up setting the default aria-labels that we just removed in the lib. Input from the accessibility team would indeed be good.

[Pytal]

Seems fine to me :)

What do you think @JuliaKirschenheuter?

[raimund-schluessler]

/l10n-update