No background for tertiary-no-background NcActions

[raimund-schluessler]

This removes the background for open NcActions of type tertiary-no-background.

Closes #3720.

Type	Before	After
tertiary
tertiary-no-background

[nimishavijay]

Looks good! One question: Are the 3 states (normal, hover and active/focus) well defined for this type of button? In the deploy-preview component there seems to be no hover state? Or is that an unrelated issue? :)

[raimund-schluessler]

Looks good! One question: Are the 3 states (normal, hover and active/focus) well defined for this type of button? In the deploy-preview component there seems to be no hover state? Or is that an unrelated issue? :)

This PR does not touch the NcButton component. So if you mean that an NcButton of type tertiary-no-background has no hover effect (neither text-color or background or similar), that's unrelated.

[susnux]

Thank you!

[nimishavijay]

Oh sorry, you are right, I meant NcButton
But seems like the NcActions component also doesn't have a hover state? There should be an explicit hover state indicated by, for eg. opacity of the icon :)

[raimund-schluessler]

Oh sorry, you are right, I meant NcButton But seems like the NcActions component also doesn't have a hover state? There should be an explicit hover state indicated by, for eg. opacity of the icon :)

That's correct. This is because NcActions uses NcButton internally. So unless we explicitly overwrite it (which we did for e.g. the background), the actions inherit the behaviour of the button. But this (missing) hover effect of a tertiary-no-background button is also not touched here 😉

I would propose to discuss/fix this in a separate issue/PR, see #3727.

[raimund-schluessler]

@nimishavijay It seems a hover feedback for tertiary-no-background was not desired, see #3727 (comment). Can we then merge this PR here now, removing the background-color?

[nimishavijay]

Yes sounds good!