fix: High contrast mode optimization #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
added
3. to review
There was a problem hiding this comment.
Very nice – I would even say your fix could be applied generally, not only for high contrast mode. Then the navigation would always have a slight border to the right, which looks a bit nicer.
For example, it looks especially strange on narrow screens when opening the navigation:
| Currently | With your patch |
|---|---|
 |
 |
It also looks very nice with the general style in bigger desktop view, with the background shining through:
What do you think @susnux? :)
nimishavijay
approved these changes
Feb 22, 2023
JuliaKirschenheuter
approved these changes
Feb 24, 2023
raimund-schluessler
approved these changes
Feb 27, 2023
|
@susnux mind sending another pull request which just adds a border in general? :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing right border on the app navigation (high contrast mode). Unify design with settings view where the app navigation has a border on the right on high contrast mode.
Changed the background color of the active element on high contrast mode, as the highlighting was barley visible.
Also applied the styles for the NcListItem to have a common styling across apps, as some apps, like the forms app, use list items instead of app navigation items (to allow a second title within the item).