-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting modal size when registering a custom picker component #3866
Allow setting modal size when registering a custom picker component #3866
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
ce9b46e
to
6b05033
Compare
/backport to stable7 |
@julien-nc Max/Jonas are out today, do you have an app that can be used for testing this already around so we can pull in someone else for another review today? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine by code, but didn't tested it yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me. Didn't test locally though.
@juliushaertl Any app implementing a custom smart picker component:
For testing this properly:
|
Design review outcome: Some custom picker components don't look good in a "large"
NcModal
.This allows to pass the desired modal size when registering a custom picker component.
This size is then used by
NcReferencePickerModal
.