Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call the link picker "smart picker" and translate more strings #3888

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Call the link picker "smart picker" and translate more strings #3888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions l10n/messages.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ msgstr ""
msgid "Back"
msgstr ""

msgid "Back to provider selection"
msgstr ""

msgid "Cancel changes"
msgstr ""

Expand All @@ -47,6 +50,9 @@ msgstr ""
msgid "Clear text"
msgstr ""

msgid "Close"
msgstr ""

msgid "Close modal"
msgstr ""

Expand All @@ -56,6 +62,9 @@ msgstr ""
msgid "Close sidebar"
msgstr ""

msgid "Close smart picker"
msgstr ""

msgid "Collapse menu"
msgstr ""

Expand Down Expand Up @@ -179,6 +188,9 @@ msgstr ""
msgid "Show password"
msgstr ""

msgid "Smart picker"
msgstr ""

msgid "Smileys & Emotion"
msgstr ""

Expand Down
2 changes: 1 addition & 1 deletion src/components/NcRichContenteditable/NcRichContenteditable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ export default {
this.updateValue(this.$refs.contenteditable.innerHTML)
})
.catch((error) => {
console.debug('Link picker promise rejected:', error)
console.debug('Smart picker promise rejected:', error)
const tmpElem = document.getElementById('tmp-link-result-node')
this.setCursorAfter(tmpElem)
tmpElem.remove()
Expand Down
9 changes: 5 additions & 4 deletions src/components/NcRichText/NcReferencePicker/NcReferencePickerModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import NcReferencePicker from './NcReferencePicker.vue'
import { isCustomPickerElementRegistered } from './customPickerElements.js'
import NcButton from '../../NcButton/index.js'
import NcModal from '../../NcModal/index.js'
import { t } from '../../../l10n.js'

import { emit } from '@nextcloud/event-bus'

Expand Down Expand Up @@ -88,9 +89,9 @@ export default {
return {
show: true,
selectedProvider: this.initialProvider,
backButtonTitle: 'Back to provider selection',
closeButtonTitle: 'Close',
closeButtonLabel: 'Close link picker',
backButtonTitle: t('Back to provider selection'),
closeButtonTitle: t('Close'),
closeButtonLabel: t('Close smart picker'),
}
},
computed: {
Expand All @@ -111,7 +112,7 @@ export default {
modalTitle() {
return this.isProviderSelected
? this.selectedProvider.title
: 'Link picker'
: t('Smart picker')
},
},
mounted() {
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcRichText/NcReferencePicker/providerHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export function getProviders() {
// avoid providers with no associated search provider and no custom component registered
const keep = (!!p.search_providers_ids && p.search_providers_ids.length > 0) || isCustomPickerElementRegistered(p.id)
if (!keep) {
console.debug('[link picker]', p.id, 'reference provider is discoverable but does not have any related search provider or custom picker component registered')
console.debug('[smart picker]', p.id, 'reference provider is discoverable but does not have any related search provider or custom picker component registered')
}
return keep
})
Expand Down