Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additionalTrapElements prop to settingsDialog #3947

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Add additionalTrapElements prop to settingsDialog #3947

merged 1 commit into from
Apr 4, 2023

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Apr 3, 2023

In the photos app the file picker inside of NcAppSettingsDialog loses focus because it's appended to the body

reproduction:

  1. open the photos app
  2. go to photos settings
  3. try changing the photos directory
  4. Navigate with tab or try adding a new folder

@hamza221
add additionalTrapElements prop to settingsDialog
bea8e11 
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 self-assigned this Apr 3, 2023
@hamza221 hamza221 added enhancement New feature or request 3. to review Waiting for reviews labels Apr 3, 2023
@hamza221 hamza221 mentioned this pull request Apr 3, 2023
Merged
@skjnldsv skjnldsv merged commit afb26e9 into master Apr 4, 2023
@skjnldsv skjnldsv deleted the enh/focus-settings-dialog branch April 4, 2023 13:08
@skjnldsv skjnldsv mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza221 @ChristophWurst @skjnldsv