Add aria-hidden attr to the whole navigation depending on a sidebar state #4016
Conversation
| display: flex; | ||
| flex-direction: column; | ||
| flex-grow: 0; | ||
| flex-shrink: 0; |
There was a problem hiding this comment.
These styles are moved from .app-navigation, which previously was the container of slots and the list, to the new container. Could we now remove them from the .app-navigation or they are still required?
There was a problem hiding this comment.
it is hard to test all apps and the risk to break something is high. I could remove https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigation/NcAppNavigation.vue#L161-L162 but would like leave it to be safe.
…tate Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/36926-The_visually_hidden_elements_of_the_navigation_on_the_left_are_always_read_by_screen_readers
branch
from
30a0eea to
1c08751
Compare
artonge
deleted the
fix/36926-The_visually_hidden_elements_of_the_navigation_on_the_left_are_always_read_by_screen_readers
branch
| display: flex; | ||
| flex-direction: column; | ||
| flex-grow: 0; | ||
| flex-shrink: 0; |
There was a problem hiding this comment.
This needs reverting it heavily breaks the talk left sidebar:
There was a problem hiding this comment.
Yep, I would have blocked if seen on time, this seems absolutely not related to this PR
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, but not all of them.
These styles are flex container styles. They should have been moved.
display: flex;
flex-direction: column;while these are flex elements styles. They should be only here.
flex-grow: 0;
flex-shrink: 0;There was a problem hiding this comment.
this seems absolutely not related to this PR
50% of these styles are flex container styles. In this PR there was created a new flex container for all content, and all flex container styles were moved to the new flex container. So, they are related.
Although, another 50% were flex element styles and really not related.
There was a problem hiding this comment.
Ok, this what i feared: it is hard to test every app. Thank you @ShGKme for explanation and fixing!
Fix an old sidebar navigation on server.
This fix is only for (where
app-navigation-vueis used):Summary
The goal of this fix: don't allow screen reader navigation through a sidebar if sidebar is closed. No visual changes.
After:
