Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use display: flex in app-content-list on mobile as well #4182

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Jun 6, 2023

We already use display: flex for app-content-list if not on mobile, see core/css/apps.scss in server repository.

☑️ Resolves

This is necessary for using position: sticky and bottom: 0 inside app-content-list.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

We already use `display: flex` for app-content-list if not on mobile,
see `core/css/apps.scss` in server repository.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added 3. to review Waiting for reviews feature: app-content-list Related to the app-content-list component labels Jun 6, 2023
@szaimen szaimen removed their request for review June 6, 2023 09:44
@mejo- mejo- requested a review from juliusknorr June 6, 2023 12:11
@JuliaKirschenheuter JuliaKirschenheuter self-requested a review June 7, 2023 08:06
@mejo- mejo- merged commit e8487c8 into master Jun 7, 2023
@mejo- mejo- deleted the fix/app_content_list_flex branch June 7, 2023 09:20
@mejo-
Copy link
Contributor Author

mejo- commented Jun 7, 2023

/backport to stable7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: app-content-list Related to the app-content-list component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants