Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly validate sidebar tabs and warn #420

Merged
merged 1 commit into from
May 31, 2019
Merged

Properly validate sidebar tabs and warn #420

merged 1 commit into from
May 31, 2019

Conversation

skjnldsv
Copy link
Contributor

Capture d’écran_2019-05-30_10-05-19

@skjnldsv
Properly validate sidebar tabs and warn
48d11ea 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels May 30, 2019
@skjnldsv skjnldsv added this to the next milestone May 30, 2019
@skjnldsv skjnldsv self-assigned this May 30, 2019
@ChristophWurst ChristophWurst merged commit f06101b into master May 31, 2019
@ChristophWurst ChristophWurst deleted the enhancement/sidebar/tab-validation-warn branch May 31, 2019 08:01
@skjnldsv skjnldsv modified the milestones: next, 0.11.4 May 31, 2019
@korelstar korelstar mentioned this pull request Jun 29, 2019
Merged
@korelstar korelstar mentioned this pull request Jul 12, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @ChristophWurst