-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NcSelect in NcRichtext #4247
Use NcSelect in NcRichtext #4247
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
42fa122
to
218f2ad
Compare
lmk if it works with nextcloud-libraries/vue-select#20 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just the timeout issue makes me wondering.
Interesting. I'll check if it helps. |
…arch Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…issue when 'searching for more' in NcRichtext's NcSearch Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@Pytal Much better with vokoscreenNG-2023-06-23_11-07-41.mp4 |
Added another commit to make sure the option keys are unique. (It's just setting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
refs #3743
Switch to
NcSelect
inNcProviderList
andNcSearch
fromNcRichText
.I couldn't figure out a way to avoid an issue with NcSearch. When selecting a "Load more..." item, even if we actually select the item while searching for more results, the selection jumps to the top and then back to the "more" item.
Not so pretty...but not so bad.
vokoscreenNG-2023-06-22_13-27-31.mp4