Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate building CommonJS module entrypoint to vite #4329

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 12, 2023

☑️ Resolves

This uses vite also for the CommonJS module entry point (index).

  • Much faster build time (18% faster)¹
  • Much smaller output asset: 400kB (vite) vs 1'020kB (webpack)

I tested it with the text app, looks good, the js assets of the text app will shrink in total by 254kB with the vite version.

¹ Run time on my system (using time npm run build):

before:  npm run build  131,93s user 7,69s system 29,180 total
after:   npm run build  117,00s user 6,73s system 23,918 total

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

* Much faster build time
* Much smaller output asset: 400kB (vite) vs 1'020kB (webpack)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews configuration Pull requests that update a config file labels Jul 12, 2023
@susnux susnux added this to the 8.0.0 milestone Jul 12, 2023
@susnux susnux requested a review from ShGKme July 13, 2023 12:51
@juliushaertl juliushaertl merged commit 32eaecb into master Jul 14, 2023
16 checks passed
@juliushaertl juliushaertl deleted the feat/cjs-module-entry-to-vite branch July 14, 2023 09:58
@susnux susnux mentioned this pull request Nov 2, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews configuration Pull requests that update a config file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants