Fix modal focus trap with additional elements and arrow navigation #4406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Two problems with focus trap break navigation with modal.
Problem 1: When Viewer is opened with sidebar, focus on the sidebar is not possible
Source:
additionalTrapElements
are not used on init but only on change.Problem 2:
NcModal
intercept arrow navigation for slider (next/prev)🖼️ Screenshots
🏚️ Before
before-1.mp4
before-2.mp4
🏡 After
after.mp4
🚧 Tasks
additionalTrapElements
on initadditionalTrapElements
🏁 Checklist