fix(NcRichContenteditable): add aria-placeholder #4407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The solution in this PR is different from the suggestion in the linked issue.
Using
aria-describedby
requires a layout update, adding a wrapper element forNcRichContenteditable
with thediv[contenteditable]
itself and a new visually hidden describing element. Though the layout of the element is not a part of its public interface, I think developers expect the component to be a directlycontenteditable
element and I prefer to keep current simple layout as long as it's possible.A good and very simple alternative solution IMO is
aria-placeholder
.🖼️ Screenshots
🚧 Tasks
aria-placeholder
🏁 Checklist