-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcRichText) - don't strip <tag>
-like content when parsing markdown
#4486
Conversation
5523b9d
to
d2ae39c
Compare
a50c839
to
34f5c82
Compare
<tag>
-like content when parsing markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works.
It solves the issue of skipping HTML-like content though there might be a better solution as follow-up .
34f5c82
to
9945cb7
Compare
5fa8e8c
to
8551e90
Compare
Rebased onto master, split commits with documentation to different PR #4507 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
8551e90
to
38606f2
Compare
Rebased onto master with some changes This returns a behavior, then Markdown parser eats newlines ( |
☑️ Resolves
white-space
rule (common for rich components)NcRichText
) - keep newlines in rendered Markdown #4461NcRichText
) - don't populate a first newline to properly parse blockqoute tags #4470<
and>
before parsing:<
could be treated like a XML tag start and be stripped with inner content (because of possible XSS attack)>
should be unescaped to correctly parse blockquotesNcRichContenteditable
pasting HTML alike content strips off text #3908🖼️ Screenshots
NcAvatar
fixease HTML
fix🚧 Tasks
🏁 Checklist