chore(vue3): add unit test for isSlotPopulated #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
3. to review
raimund-schluessler
requested review from
susnux,
juliushaertl,
skjnldsv,
Pytal and
ShGKme
raimund-schluessler
force-pushed
the
chore/2154/slot-populated
branch
from
43e1ccb
to
8a2295d
Compare
ShGKme
approved these changes
Sep 10, 2023
juliushaertl
approved these changes
Sep 11, 2023
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
chore/2154/slot-populated
branch
from
35d4177
to
09ceebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test for the
isSlotPopulatedutil. This util is made to check whether a slot actually contains content. I also slightly changed it to check whether there is only an empty Text node.In vue 3 the usual way used in vue 2 does not work anymore.
Both
!!this.$slots.defaultand!!this.$slots.default?.()will basically always betrue.