Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): adjust paddings and hover styles for list items #4628

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix(NcListItem): adjust paddings and hover styles for list items #4628

merged 1 commit into from
Oct 10, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 9, 2023

☑️ Resolves

🖼️ Screenshots

Top to bottom: .active, .active:hover, .active:focus, .active:focus-visible

Screenshot from 2023-10-09 16-23-42

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Check if other components were aligned to this <slot name="icon" /> => move also for +2px

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Antreesy
fix(NcListItem): adjust paddings and hover styles for list items
451ebf8 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: list-item Related to the list-item component labels Oct 9, 2023
@Antreesy Antreesy added this to the 8.0.0 milestone Oct 9, 2023
@Antreesy Antreesy self-assigned this Oct 9, 2023
szaimen
szaimen approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@Antreesy Antreesy merged commit 481569b into master Oct 10, 2023
15 checks passed
@Antreesy Antreesy deleted the fix/4625/adjust-nclistitem-styles branch October 10, 2023 02:22
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
@DorraJaouad DorraJaouad mentioned this pull request Oct 31, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@szaimen szaimen szaimen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: list-item Related to the list-item component
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

NcListItem has inconsistent styles for active elements
3 participants
@Antreesy @marcoambrosini @szaimen