Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActionInput): Set default trailing button label #4632

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(NcActionInput): Set default trailing button label #4632

merged 1 commit into from
Oct 11, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 10, 2023

Summary

  • Set default trailing button label to match click handler "$refs.form.requestSubmit()" behaviour
  • Remove redundant NcPasswordField props

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal
fix(NcActionInput): Set default trailing button label
d59faf8 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components feature: input-field Covering the InputField, TextField, ... labels Oct 10, 2023
@Pytal Pytal added this to the 8.0.0 milestone Oct 10, 2023
@Pytal Pytal self-assigned this Oct 10, 2023
@Pytal
Copy link
Contributor Author

Pytal commented Oct 10, 2023

/backport to stable7

@Pytal Pytal mentioned this pull request Oct 10, 2023
Merged
3 tasks
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2023
@Pytal Pytal merged commit 16eab2c into master Oct 11, 2023
@Pytal Pytal deleted the fix/text-field-trailing-label branch October 11, 2023 18:31
@Pytal Pytal mentioned this pull request Oct 11, 2023
Merged
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: actions Related to the actions components feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @JuliaKirschenheuter @ShGKme