fix(Nc*Field): do not pass all props to InputField BY filtering $props #4666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
HTML Validation issue.
Currently
NcTextField
passes both$attrs
and$props
to theNcInputField
.While passing
$attrs
makes sense, passing$props
is valid only when both components have exactly the same props. But they don't.NcTextField
has its own proptrailingButtonIcon
and may have more props in the future.Proposal: same as
NcSelect
.Filter props to proxy only original
NcInputField
props.Alternative solution: do not use props for proxying.
See: #4665
🖼️ Screenshots
trailingbuttonicon
is not a valid<input>
attribute.🏁 Checklist