Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDashboardWidgetItem): do not assign href="" with empty link #4672

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(NcDashboardWidgetItem): do not assign href="" with empty link #4672

merged 1 commit into from
Oct 19, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 19, 2023

☑️ Resolves

When NcDashboardWidgetItem has empty targetUrl, it is rendered as div, but still has href="" which is not a valid HTML

🖼️ Screenshots

No visual changes

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme
fix(NcDashboardWidgetItem): do not assign href="" with empty link
7ddd071 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: dashboard Related to the dashboard widget labels Oct 19, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Oct 19, 2023
@ShGKme ShGKme self-assigned this Oct 19, 2023
szaimen
szaimen approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux susnux merged commit ad1963e into master Oct 19, 2023
14 checks passed
@susnux susnux deleted the fix/dashboard--html-validation branch October 19, 2023 13:32
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: dashboard Related to the dashboard widget
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @susnux @szaimen