Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): fix component registration #4685

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(dialog): fix component registration #4685

merged 1 commit into from
Oct 23, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 23, 2023

☑️ Resolves

@ShGKme
fix(dialog): fix component registration
bb264ec 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: dialog Related to the dialog component labels Oct 23, 2023
@ShGKme ShGKme self-assigned this Oct 23, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 23, 2023

Testing in styleguidist doesn't show the problem, because it registers all Nextcloud/Vue components globally

@ShGKme ShGKme added this to the 8.0.0 milestone Oct 23, 2023
@susnux
Copy link
Contributor

susnux commented Oct 23, 2023

I meant to comment on the other one instead of approve 🙈

@susnux susnux merged commit 3bba9e1 into master Oct 23, 2023
15 checks passed
@susnux susnux deleted the fix/dialogs--component-registration branch October 23, 2023 14:44
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: dialog Related to the dialog component
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @susnux @raimund-schluessler