Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcTimezonePicker): Add correct aria-label #4762

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix(NcTimezonePicker): Add correct aria-label #4762

merged 1 commit into from
Nov 7, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 7, 2023 •
edited
Loading

☑️ Resolves

Change aria-label to reflect that you select time zones.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 7, 2023
@susnux susnux added this to the 8.0.0 milestone Nov 7, 2023
@susnux susnux force-pushed the fix/timezone-aria-label branch from 24ec8ef to c60b735 Compare November 7, 2023 00:06
@susnux
fix(NcTimezonePicker): Add correct aria-label
19380fb 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/timezone-aria-label branch from c60b735 to 19380fb Compare November 7, 2023 11:12
@susnux susnux mentioned this pull request Nov 7, 2023
Merged
16 tasks
@susnux susnux merged commit bcfa436 into master Nov 7, 2023
15 checks passed
@susnux susnux deleted the fix/timezone-aria-label branch November 7, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[BITV]: NcSelect improvements
3 participants
@susnux @JuliaKirschenheuter @ShGKme