fix(NcActions): fix role and aria attributes #4835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcActions
andNcAction*
items should have correct menu roles only when it represents a menu.See detailed requirement in the comment here: nextcloud/server#37099 (comment)
🖼️ Screenshots
🚧 Tasks
NcActionSeparator
: addrole="separator"
NcActionButtonGroup
: addrole="group"
andaria-labelledby
NcActionsButton
andNcButton
:- Always set
aria-hidden="true"
onspan.icon
in default#icon
-
ariaHidden
props. Developers don't need to set it manually, it is always needed by defaultNcActions
:- Change rule to determine when actions has
role="menu"
- Provide
NcActions:inSemanticMenu
, toNcAction*
may know if they are inrole="menu"
- Only in a menu:
-
LI
hasrole="presentation"
-
BUTTON
hasrole="menuitem"
- In
NcActionCheckbox/NcActionRadio
:-
span
hasrole="menuitemcheckbox"
orrole="menuitemradio"
-
span
has correctaria-checked
🏁 Checklist