Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/470/split appnavigationitem into small components #486

Merged

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Jul 17, 2019

Fix #470
Fix #376

  • Replace the pinned script with pure css;
  • Fix the out of bounds popover menu;
  • Fix collapsing icon with long titles;
  • Fix overflow text of AppNavigationItem's title;
  • Emit click event from AppNavigationCaption;

Please use this App.vue in you vueexample app for reviewing, as the new components won't work with the old one!

@marcoambrosini marcoambrosini force-pushed the feature/470/split-appnavigationitem-into-small-components branch from e40198d to 6467b56 Compare July 17, 2019 12:49
@marcoambrosini marcoambrosini self-assigned this Jul 18, 2019
Copy link
Contributor

@korelstar korelstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't look like it is finished, but the tags and review requests say so. Hence, I did a fast review on the code, but I didn't test it in practice. This has to be done later.

src/components/AppNavigationItem/AppNavigationItem.vue Outdated Show resolved Hide resolved
src/assets/variables.scss Outdated Show resolved Hide resolved
src/components/AppNavigationItem/AppNavigationItem.vue Outdated Show resolved Hide resolved
@marcoambrosini
Copy link
Contributor Author

This PR doesn't look like it is finished, but the tags and review requests say so. Hence, I did a fast review on the code, but I didn't test it in practice. This has to be done later.

Yep, sorry.. I just created it because I needed a bit of feedback/guidance (which you provided)! Thank you!

@juliusknorr juliusknorr added 2. developing Work in progress feature: app-navigation Related to the app-navigation component labels Jul 21, 2019
@skjnldsv skjnldsv force-pushed the feature/470/split-appnavigationitem-into-small-components branch from f2c1914 to 46039cd Compare July 22, 2019 14:06
Copy link
Contributor

@korelstar korelstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things, see comments.

Edit: And the performance issue is still there.

@skjnldsv skjnldsv force-pushed the feature/470/split-appnavigationitem-into-small-components branch from 3fcb09b to ff0d1e1 Compare September 4, 2019 07:45
@marcoambrosini
Copy link
Contributor Author

Thanks @korelstar for yr thorough review!

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@skjnldsv skjnldsv force-pushed the feature/470/split-appnavigationitem-into-small-components branch from ff0d1e1 to 6106e77 Compare September 4, 2019 08:18
@skjnldsv
Copy link
Contributor

skjnldsv commented Sep 4, 2019

@korelstar all clear and rebased!
I reviewed again! All looks good to me :)

I'd say let's merge and individually fix the tiny issues we could find + do a proper aria pass on it!

Copy link
Contributor

@korelstar korelstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
Good thing! Last remaining drawback is the slow performance compared to the situation before this PR. I strongly suggest to fix this before the next release.

@skjnldsv
Copy link
Contributor

skjnldsv commented Sep 5, 2019

Good thing! Last remaining drawback is the slow performance compared to the situation before this PR. I strongly suggest to fix this before the next release.

Could you perform a lighthouse? Or a performance audit?

@skjnldsv skjnldsv merged commit 4489801 into master Sep 5, 2019
@skjnldsv skjnldsv deleted the feature/470/split-appnavigationitem-into-small-components branch September 5, 2019 05:07
@korelstar
Copy link
Contributor

I can try this. Honestly, I never did this before. Which tool do you suggest?

@skjnldsv
Copy link
Contributor

skjnldsv commented Sep 5, 2019

default brwoser tool. Either lighthouse or the profiling tab on chroomium or performance on firefox :)

@korelstar
Copy link
Contributor

I've created a new issue for the performance problem: #577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-navigation Related to the app-navigation component feature: documentation Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split AppNavigationItem into small components AppNavigationItem extensions necessary for Talk
6 participants