-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAvatar): Increase contrast of avatar status icon #4912
Conversation
Is it the contrast of the icon to the background? I read the issue as if the color of the status indicator does not have enough contrast meaning the green on the white. So we should maybe adjust the SVGs for the status icons (and use the --color-success etc variables, this this possible?) as the our variables are tested to have high enough contrast. |
yeah, this would be good if this fixes the problem :) |
121e8b7
to
93d3ac2
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
356ab14
to
e91080b
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
e91080b
to
b93aeaa
Compare
Remember to add |
🖼️ Screenshots
🏁 Checklist