-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcCheckboxRadioSwitch): improve rendering and prevent unecessary elements #5001
Conversation
skjnldsv
commented
Dec 28, 2023
- Make the icon inert
- Do not render the content text if undefined
I don't understand... Icon Is it an alternative or a part of #4999 ? |
From what I am seeing, the |
It would be an a11y issue if there was an interactive focusable and yet inert element... |
That's the point, sanitising what we allow in those slots.
No, It just happen that I branched it from the other PR, it will change its base branch once #4999 is merged |
34a1a7f
to
9511e3f
Compare
…elements Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
9511e3f
to
54851fd
Compare