Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcCheckboxRadioSwitch): correctly declare update:modelValue #5006

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: checkbox-radio-switch Related to the checkbox-radio-switch component vue 3 Related to the vue 3 migration labels Dec 28, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Dec 28, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review December 28, 2023 13:33
@raimund-schluessler raimund-schluessler changed the title fix(NcCheckboxRadioSwitch): correctly declare update:modelValue [next] fix(NcCheckboxRadioSwitch): correctly declare update:modelValue Dec 28, 2023
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Contributor Author

Seems like I wasn't fully awake when creating #4994. I missed migrating the examples in the docs and pushed a few minor changes here to fix this.

@skjnldsv skjnldsv merged commit 7b7d07f into next Dec 29, 2023
14 checks passed
@skjnldsv skjnldsv deleted the fix/noid/emit-model-value branch December 29, 2023 13:31
@susnux susnux mentioned this pull request Jan 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants