Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcBreadcrumb): fix setting class on root element #5010

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Dec 29, 2023

☑️ Resolves

  • Fix setting class on the root element of NcBreadcrumb. This is necessary to correctly set the dropdown class for the breadcrumb containing the hidden crumbs. This fixes a visual issue with the alignment of the three-dots icon.

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: breadcrumbs Related to the breadcrumbs components vue 3 Related to the vue 3 migration labels Dec 29, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Dec 29, 2023
@raimund-schluessler raimund-schluessler changed the title fix(NcBreadcrumb): fix setting class on root element [next] fix(NcBreadcrumb): fix setting class on root element Dec 29, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review December 29, 2023 20:44
@skjnldsv skjnldsv merged commit d8d2621 into next Jan 2, 2024
15 checks passed
@skjnldsv skjnldsv deleted the fix/noid/breadcrumb-dropdown branch January 2, 2024 11:34
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 2, 2024
@susnux susnux mentioned this pull request Jan 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: breadcrumbs Related to the breadcrumbs components vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants