Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(test): correctly provide props in test #5012

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

  • Fixes the way we provide props to the mount function in modal.spec.js for vue 3.

@susnux Since the tests passed even though we didn't provide the props correctly, I assume the tests don't really test anything. I didn't change it here though, since it is the same in master and should probably be fixed there, I think.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Dec 30, 2023
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: modal Related to the modal component vue 3 Related to the vue 3 migration labels Dec 30, 2023
@susnux
Copy link
Contributor

susnux commented Dec 30, 2023

Since the tests passed even though we didn't provide the props correctly

Yes but the test utils have a fallback so it still set the props correctly:
https://github.com/vuejs/test-utils/blob/b1c2388c3422115f0a7d2627fe308f44f4145462/src/createInstance.ts#L173

@raimund-schluessler
Copy link
Contributor Author

Yes but the test utils have a fallback so it still set the props correctly: https://github.com/vuejs/test-utils/blob/b1c2388c3422115f0a7d2627fe308f44f4145462/src/createInstance.ts#L173

Ah, thanks for the hint. I wasn't aware of this. They apparently think ahead 😆

@ShGKme ShGKme merged commit 179aaf1 into next Dec 30, 2023
14 checks passed
@ShGKme ShGKme deleted the fix/noid/modal-test branch December 30, 2023 22:45
@susnux susnux mentioned this pull request Jan 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: modal Related to the modal component vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants