feat: Add NcUserStatusIcon #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
enhancement
3 tasks
ShGKme
requested changes
Jan 12, 2024
|
What about also support displaying emoji status icon in this component? |
ShGKme
reviewed
Jan 12, 2024
ShGKme
reviewed
Jan 12, 2024
Pytal
force-pushed
the
feat/user-status-icon
branch
from
ddd53c4 to
0b7fd8b
Compare
Not sure there is a large benefit as emojis are just strings, let me know if there is a strong reason to though :) |
Pytal
force-pushed
the
feat/user-status-icon
branch
4 times, most recently
from
cfa113b to
e8e2bfb
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/user-status-icon
branch
from
e8e2bfb to
57c3eb6
Compare
ShGKme
approved these changes
Jan 16, 2024
raimund-schluessler
approved these changes
Jan 16, 2024
|
The code looks fine. But the new server colors for success and warning look depressing. |
Pytal
added
the
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new NcUserStatusIcon component for accessibility
🖼️ Screenshots
🏁 Checklist