Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcReferenceList): Add support for a fallback reference widget #5092

Merged
merged 1 commit into from
Jan 23, 2024
Merged

feat(NcReferenceList): Add support for a fallback reference widget #5092

merged 1 commit into from
Jan 23, 2024

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Jan 18, 2024

Allow to render a fallback widget if no other reference widget loads.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@mejo- mejo- added enhancement New feature or request 4. to release Ready to be released and/or waiting for tests to finish labels Jan 18, 2024
@mejo- mejo- requested a review from juliusknorr January 18, 2024 17:16
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: richtext Related to the richtext component and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jan 18, 2024
@juliusknorr juliusknorr force-pushed the feat/reference_list_fallback branch from 0770c17 to 5e78c00 Compare January 23, 2024 07:11
max-nextcloud
max-nextcloud approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Have not tested it though.

What would this look like in use?

@mejo-
feat(NcReferenceList): Add support for a fallback reference widget
45ecc91 
Allow to render a fallback widget if no other reference widget loads.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/reference_list_fallback branch from 5e78c00 to 45ecc91 Compare January 23, 2024 11:41
@mejo- mejo- mentioned this pull request Jan 23, 2024
Merged
@mejo- mejo- merged commit e2674e0 into master Jan 23, 2024
15 checks passed
@mejo- mejo- deleted the feat/reference_list_fallback branch January 23, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mejo- @juliusknorr @max-nextcloud @raimund-schluessler