Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcPopover): fix docs example #5111

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix(NcPopover): fix docs example #5111

merged 1 commit into from
Jan 22, 2024

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

Fixes a typo in the NcPopover docs. Not critical for vue 2, but breaks the example for vue 3.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added this to the 8.5.0 milestone Jan 22, 2024
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: popover Related to the popovermenu component feature: documentation Related to the documentation labels Jan 22, 2024
@raimund-schluessler raimund-schluessler marked this pull request as ready for review January 22, 2024 14:30
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@Pytal Pytal merged commit 8d24adf into master Jan 22, 2024
16 checks passed
@Pytal Pytal deleted the fix/noid/popover-docs branch January 22, 2024 20:31
@Pytal Pytal mentioned this pull request Jan 23, 2024
@susnux susnux added the bug Something isn't working label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: documentation Related to the documentation feature: popover Related to the popovermenu component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants