Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcModal): scope modal-container size to current modal, don't propagate it on nested #5244

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix(NcModal): scope modal-container size to current modal, don't propagate it on nested #5244

merged 1 commit into from
Feb 12, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2024-02-12 10-48-17 image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcModal): scope modal-container size to current modal, don't prop…
dba41bd 
…agate it on nested

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: modal Related to the modal component labels Feb 12, 2024
@Antreesy Antreesy added this to the 8.6.3 milestone Feb 12, 2024
@Antreesy Antreesy self-assigned this Feb 12, 2024
@Antreesy
Copy link
Contributor Author

/backport to next

@Antreesy Antreesy merged commit e94a7cb into master Feb 12, 2024
18 checks passed
@Antreesy Antreesy deleted the fix/5228/scope-ncmodal-size branch February 12, 2024 13:36
@backportbot backportbot bot mentioned this pull request Feb 12, 2024
Closed
@susnux susnux modified the milestones: 8.6.3, 8.7.0 Feb 18, 2024
@skjnldsv skjnldsv mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: modal Related to the modal component
Projects
None yet
Milestone
8.7.0
Development

Successfully merging this pull request may close these issues.

NcModal doesn't respect nested Modal style
4 participants
@Antreesy @ShGKme @DorraJaouad @susnux