feat: Add NcAppNavigationList #5302
Conversation
Pytal
added
enhancement
Pytal
requested review from
susnux,
JuliaKirschenheuter,
ShGKme and
emoral435
| @@ -66,7 +66,7 @@ emit('toggle-navigation', { | |||
| @keydown.esc="handleEsc"> | |||
| <slot /> | |||
| <!-- List for Navigation li-items --> | |||
| <ul class="app-navigation__list"> | |||
| <ul v-if="hasListSlotItems" class="app-navigation__list"> | |||
There was a problem hiding this comment.
Is ul.app-navigation__list different from NcAppNavigationList?
There was a problem hiding this comment.
Also stumbled over this one, could we not just use NcAppNavigationList here instead?
There was a problem hiding this comment.
Is
ul.app-navigation__listdifferent fromNcAppNavigationList?
Yes slightly. The difference is ul.app_navigation__list always fills the height that is not already taken up by its siblings inside nav.app-navigation__content but when we have separate lists inside the nav we want don't want that e.g.
so we adjust the styles in NcAppNavigationList to keep the styling we want:
The .app_navigation__list styles also target .app_navigation__content > ul which we should keep to not break anything, so we also increase the specificity to have the styles apply correctly
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/app-nav-list
branch
from
3c4bee4 to
ff033b3
Compare
|
/backport to next |
☑️ Resolves
uls inside NcAppNavigation makes sense i.e. using NcAppNavigationCaption as a label for the nextul🏁 Checklist
nextrequested with a Vue 3 upgrade