fix(NcActions): clear focus trap and move focus only if elements are existing in the DOM #5345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
clearForcusTrap
#5292There are couple of places, where triggering an action in NcActions (by click, for example) leads to unmounting / breaking re-rendering of NcActions immediately. (Examples in Talk: stop the screensharing (stable28), end the call (main)). In such cases, after
nextTick
ref elements (popover, menuButton) are no longer present in the DOM (undefined
), thus attempt to call methods on them lead to an error (see issues).Popover has
clearFocusTrap
in beforeDestroy hook, so changes should be safe to apply (regarding previous PR)🖼️ Screenshots
No behaviour change, just clean console 🧹
🏁 Checklist
next
requested with a Vue 3 upgrade