Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigation): stretch the main content when there is no list slot #5360

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix(NcAppNavigation): stretch the main content when there is no list slot #5360

merged 1 commit into from
Mar 6, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 6, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

Files Users Talk Mail Contacts
image image image image image
Files Users Talk Mail Contacts

css

🚧 Tasks

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme
fix(NcAppNavigation): stretch main content when no list
596c22a 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels Mar 6, 2024
@ShGKme ShGKme added this to the 8.9.2 milestone Mar 6, 2024
@ShGKme ShGKme self-assigned this Mar 6, 2024
@ShGKme ShGKme requested a review from emoral435 March 6, 2024 18:43
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

Pytal
Pytal approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is clean and works nicely!

@ShGKme ShGKme merged commit f8d6260 into master Mar 6, 2024
18 checks passed
@ShGKme ShGKme deleted the fix/nc-app-navigation--stretch-content-without-list branch March 6, 2024 20:48
@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 8, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 8, 2024
Merged
2 tasks
@ShGKme ShGKme modified the milestones: 8.9.2, 8.10.0 Mar 8, 2024
@ShGKme ShGKme mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Pytal approved these changes

@susnux susnux Awaiting requested review from susnux

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
8.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @JuliaKirschenheuter @Pytal