Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppSidebar): remove always hover styles from actions in non-compact mode #5367

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix(NcAppSidebar): remove always hover styles from actions in non-compact mode #5367

merged 3 commits into from
Mar 20, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 7, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Mar 7, 2024
@ShGKme ShGKme added this to the 8.10.0 milestone Mar 7, 2024
@ShGKme ShGKme self-assigned this Mar 7, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 7, 2024

/backport to next

susnux
susnux approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@susnux susnux requested a review from szaimen March 8, 2024 10:55
@susnux
Copy link
Contributor

susnux commented Mar 8, 2024

I tried to fix the screenshots but this is a mess... Wish we have a command for it...

@ShGKme ShGKme modified the milestones: 8.10.0, 8.10.1, 8.11.0, 8.11.1 Mar 11, 2024
ShGKme added 2 commits March 20, 2024 19:51
@ShGKme
fix(NcAppSidebar): remove always hover styles from actions in non-com…
d9b431f 
…pact mode

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(NcAppSidebar): remove unneeded styles from actions
13616a6 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/nc-app-sidebar--remove-always-hover-style-from-actions branch 2 times, most recently from 4711d39 to e652fd0 Compare March 20, 2024 15:15
@susnux @ShGKme
fix(tests): Adjust screenshots for visual testing
58522b4 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@ShGKme ShGKme force-pushed the fix/nc-app-sidebar--remove-always-hover-style-from-actions branch from e652fd0 to 58522b4 Compare March 20, 2024 15:22
@ShGKme ShGKme merged commit bded712 into master Mar 20, 2024
19 checks passed
@ShGKme ShGKme deleted the fix/nc-app-sidebar--remove-always-hover-style-from-actions branch March 20, 2024 15:39
@backportbot backportbot bot mentioned this pull request Mar 20, 2024
Merged
@Antreesy Antreesy mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@susnux susnux susnux approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
8.11.1
Development

Successfully merging this pull request may close these issues.

Three dots menu button on task details sidebar always looks selected
3 participants
@ShGKme @susnux @Pytal