fix(NcReferenceWidget): do not try to render widget when there is no widget #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
ShGKme
changed the title
ShGKme
force-pushed
the
fix/widgets--append-child-to-non-existing-widget
branch
from
bd6095f to
220b64e
Compare
juliusknorr
approved these changes
Apr 11, 2024
Antreesy
approved these changes
Apr 11, 2024
…widget Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Antreesy
force-pushed
the
fix/widgets--append-child-to-non-existing-widget
branch
from
220b64e to
f156a21
Compare
|
Rebased fot Cypress fix |
|
/backport to next |
This was referenced Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcReferenceWidgetalways tries to render the widget intoref="customWidget", butref="customWidget"exists only when there is a custom widget (reference && hasCustomWidget), for example, if the widget is not registered yet there is no div to render the widget.It doesn't look like a bug for the end user, but spams with errors on the console.