Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust license in package.json #5612

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: Adjust license in package.json #5612

merged 1 commit into from
May 28, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 17, 2024

☑️ Resolves

We are using AGPL-3.0 or later, so adjust the package.json to reflect this

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels May 17, 2024
@susnux
Copy link
Contributor Author

susnux commented May 17, 2024

/backport to next

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong, but I though it is not valid to change 3.0 to 3-or-later... cc @nickvergessen

ShGKme

This comment was marked as duplicate.

@susnux
Copy link
Contributor Author

susnux commented May 19, 2024

@ShGKme relicensing is not possible without asking every contributor (if they are from community). But this is not re-licensing the library but fixing it. Every file in the source is AGPL-3.0-or-later, there is no AGPL-3.0 (or correctly AGPL-3.0-only) file.

@ShGKme
Copy link
Contributor

ShGKme commented May 19, 2024

Every file in the source is AGPL-3.0-or-later

Indeed

@skjnldsv
Copy link
Contributor

skjnldsv commented May 21, 2024

Every file in the source is AGPL-3.0-or-later

Except the package(-lock).json 🙈

EDIT, as the initial creator of the file, maybe me approving is worth something for a license update?

@ShGKme
Copy link
Contributor

ShGKme commented May 21, 2024

Except the package(-lock).json 🙈

Does it actually have its own license? Not the license property which determines the package license (and where AGPL-3.0 also means AGPL-3.0-or-later)

@skjnldsv
Copy link
Contributor

Does it actually have its own license?

I would (maybe wrongly) assume that every file have its own license anyway 🤔

@susnux
Copy link
Contributor Author

susnux commented May 21, 2024

Except the package(-lock).json 🙈

Does it actually have its own license? Not the license property which determines the package license (and where AGPL-3.0 also means AGPL-3.0-or-later)

Not sure it even satisfies the threshold of originality, but if you agree here it would be simpler ;)

We are using AGPL-3.0 or later, so adjust the package.json to reflect this

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 73bea54 into master May 28, 2024
18 checks passed
@susnux susnux deleted the fix/license branch May 28, 2024 12:28
Copy link

backportbot bot commented May 28, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5612/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bbd5a98a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5612/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants