-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add SPDX headers and REUSE CI workflow #5650
Conversation
@susnux many files lack the |
The year isn't mandatory but strongly suggested I would say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me to merge, still some files missing the year info, which is fine I guess, any header is better than none 👍
23536de
to
7bd0a7e
Compare
@ShGKme fine to merge? Changes needed? :) |
/backport to next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still globs in reuse with glob extension (see comment above). I was told by @nickvergessen that this is not good as may potentially take more files than needed.
Other than that looks fine. Checked with https://github.com/nextcloud/github_helper/tree/master/spdx-convertor adjusted to this repo.
@ShGKme you mean #5650 (comment) as in the wildcards are to wide? |
@susnux I'll take care of fixing the images and licenses in reuse 👍 |
Yes, but I haven't found Joas's comment about it in Talk Desktop's PR, may be It was in my dream. confirming with Joas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is not correct with this glob, same as it was on server.
Some files are not from Nextcloud, see:
https://github.com/nextcloud/server/blob/59c181b4cbc47821d0a7d35df747a8b1d012dfc7/.reuse/dep5#L158-L160
We should copy this block from server (and somehow maintain it 🥲)
Ah, yes. That I will fix myself on this PR since I also did that on server including replacing the icon for Material Symbol ones 👍 Thanks for the feedback @ShGKme - now it is clear to me what needs to be done 👍 |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…tion Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
91376a8
to
b56a8b5
Compare
The backport to # Switch to the target branch and update it
git checkout next
git pull origin next
# Create the new backport branch
git checkout -b backport/5650/next
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 73ea7253 d451d1bd f33d8db9 b56a8b5b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5650/next Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
@susnux could you maybe take care of the forward porting to |
@AndyScherzinger yes |
*⚠️ this is chained on #5647☑️ Resolves
Add SPDX headers to all files
🏁 Checklist
next
requested with a Vue 3 upgrade