fix(NcModal): Adjust modal header name and actions #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix size and margin of header name to work with new server styles on Nextcloud 30+ - Fix focus-visible, hover and open color of header actions on bright color theme Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
raimund-schluessler,
artonge,
skjnldsv,
ShGKme and
marcoambrosini
|
/backport to next |
ShGKme
reviewed
May 31, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
approved these changes
May 31, 2024
3 tasks
ShGKme
approved these changes
Jun 14, 2024
marcoambrosini
approved these changes
Jun 14, 2024
|
SPDX header is missing 🥲 |
4 tasks
skjnldsv
reviewed
Jul 13, 2024
| @@ -214,10 +217,10 @@ export default { | |||
| tabindex="-1"> | |||
| <!-- Header --> | |||
| <transition name="fade-visibility" appear> | |||
| <div class="modal-header"> | |||
| <div class="modal-header" data-theme-dark> | |||
There was a problem hiding this comment.
This doesn't seem to work if a theme is enforced
There was a problem hiding this comment.
That requires a fix on server I think, to ensure we at least load the dark theme with data attribute if another one is enforced 🤔
There was a problem hiding this comment.
But then talk has a problem as they are using this to have the dark "chat view" on every theme
There was a problem hiding this comment.
Yes, that's k, this is an edge case :)
Hope the server fix suits you! 👍
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@artonge this will fix the currently failing visual regression tests of Activity.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade