-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAppSidebar): apply toggle offset transition only on sidebar transition #5720
Merged
ShGKme
merged 1 commit into
master
from
fix/NcAppSidebar--remove-toggle-animation-on-appear
Jun 19, 2024
Merged
fix(NcAppSidebar): apply toggle offset transition only on sidebar transition #5720
ShGKme
merged 1 commit into
master
from
fix/NcAppSidebar--remove-toggle-animation-on-appear
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsition Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
bug
Something isn't working
3. to review
Waiting for reviews
feature: app-sidebar
Related to the app-sidebar component
labels
Jun 19, 2024
ShGKme
requested review from
AndyScherzinger,
susnux,
marcoambrosini and
Antreesy
June 19, 2024 15:31
AndyScherzinger
approved these changes
Jun 19, 2024
marcoambrosini
approved these changes
Jun 19, 2024
Antreesy
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
/backport to next |
The backport to # Switch to the target branch and update it
git checkout next
git pull origin next
# Create the new backport branch
git checkout -b backport/5720/next
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d5a2a7a9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5720/next Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
4 tasks
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
backport-request
bug
Something isn't working
feature: app-sidebar
Related to the app-sidebar component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
Slowed down to be more visible on gifs
🚧 Tasks
--app-sidebar-offset
transition by default--app-sidebar-offset
transition whenNcAppSidebar
transition is active🏁 Checklist
next
requested with a Vue 3 upgrade