Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcAppSidebar): force show navigation for a single tab #5740

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 27, 2024

☑️ Resolves

  • Allows to show a tab navigation if there is only one tab available
  • Should be non-interactive, act as a visual header

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Discuss on disabling:
    • keydown events
    • mouse events
    • aria-attributes

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Jun 27, 2024
@Antreesy Antreesy added this to the 8.14.0 milestone Jun 27, 2024
@Antreesy Antreesy requested review from susnux and ShGKme June 27, 2024 08:48
@Antreesy Antreesy self-assigned this Jun 27, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Jun 27, 2024

Discuss on disabling:

  • keydown events
  • mouse events
  • aria-attributes

I'd say, it is fine. Yes, it doesn't make much sense to have tab navigation with one tab, but from a11y perspective it is still "active tab one of one"

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just one comment about the prop naming but no blocker as I am fine with both if you agree.

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/noid/force-sidebar-navigation branch from 1df8d31 to e34ca2c Compare June 29, 2024 06:48
@Antreesy Antreesy merged commit 8d5a62f into master Jun 29, 2024
19 checks passed
@Antreesy Antreesy deleted the feat/noid/force-sidebar-navigation branch June 29, 2024 07:57
@susnux
Copy link
Contributor

susnux commented Jul 1, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants