Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcActions): Use full window height #5806

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 15, 2024

☑️ Resolves

Calculate the space on the window based on the trigger location.

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2024-07-15 at 15-18-35 Nextcloud Vue Style Guide Screenshot 2024-07-15 at 15-18-00 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Calculate the space on the window based on the trigger location.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Jul 15, 2024
@susnux susnux added this to the 8.14.1 milestone Jul 15, 2024
@susnux susnux requested review from Pytal, ShGKme and Antreesy July 15, 2024 13:18
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a bunch! :)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from Antreesy July 15, 2024 20:32
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better (if change container prop in addition, but that's a todo for me now)
image

@susnux susnux merged commit c0a0eb0 into master Jul 16, 2024
19 checks passed
@susnux susnux deleted the fix/actions-use-full-height branch July 16, 2024 10:17
@susnux
Copy link
Contributor Author

susnux commented Jul 16, 2024

/backport to next

@@ -1130,7 +1131,7 @@ export default {
*/
boundariesElement: {
type: Element,
default: () => document.querySelector('body'),
default: () => document.querySelector('#app-content-vue') ?? document.querySelector('body'),
Copy link
Contributor

@Antreesy Antreesy Jul 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, we didn't check, and that's breaking NcActions in the NcAppNavigation and NcAppSidebar.Shouldn't it be #content-vue, as in NcContent?

a b
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menus do not show completely even if there is vertical space, always restricted to 50%
4 participants