Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppNavigationSearch): Fix focus button when clearing search #5850

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 22, 2024

☑️ Resolves

Merged too fast 🙈
Now that the ref is pointing to a plain HTML element, there is no $el...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Jul 22, 2024
@susnux susnux added this to the 8.15.0 milestone Jul 22, 2024
@susnux susnux changed the title fix(NcAppNavigationSearch): Fix focus button on search clear fix(NcAppNavigationSearch): Fix focus button when clearing search Jul 22, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants