Skip to content

chore(NcAppSidebar): correctly define and document exposed CSS variables #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

chore(NcAppSidebar): correctly define and document exposed CSS variables #5861

merged 3 commits into from
Jul 16, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 24, 2024 •
edited by susnux
Loading

☑️ Resolves

  • Although AppSidebar's and AppNavigation's toggle button paddings have the same value, they don't have a single source
  • Replaced using navigation SCSS variable in the sidebar with the direct value
  • Fixed docs for --app-sidebar-offset
  • Added "Exposed CSS Variables" docs section

🖼️ Screenshots

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to stable8 requested

@ShGKme ShGKme added 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Jul 24, 2024
@ShGKme ShGKme added this to the 8.15.1 milestone Jul 24, 2024
@ShGKme ShGKme requested review from susnux, Pytal and Antreesy July 24, 2024 12:09
@ShGKme ShGKme self-assigned this Jul 24, 2024
@susnux
Copy link
Contributor

susnux commented Jul 24, 2024

Thank you this is a very nice thing :)

@ShGKme ShGKme force-pushed the chore/nc-app-sidebar--do-not-use-nc-app-navigation-vars branch from 01b3b29 to 38a9884 Compare July 24, 2024 12:18
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2024

Force pushed just a commit message typo fix

@ShGKme ShGKme mentioned this pull request Jul 24, 2024
Draft
3 tasks
@susnux
Copy link
Contributor

susnux commented Jul 24, 2024

@ShGKme you need to update cypress snapshots 🙈

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2024

@ShGKme you need to update cypress snapshots 🙈

I changed nothing 🥲

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2024

Will do so later today

@susnux
Copy link
Contributor

susnux commented Jul 24, 2024

I changed nothing 🥲

Maybe a padding or something else moved like 1px?

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2024

Ok, actually, it is relevant. Variables are defined on an element outside the AppSidebar which doesn't work for Cypress.

@susnux
Copy link
Contributor

susnux commented Jul 24, 2024

Ok, actually, it is relevant. Variables are defined on an element outside the AppSidebar which doesn't work for Cypress.

Put it into NcContent in the cypress tests? For the PlayWright migration this was done 😅

susnux
susnux reviewed Jul 24, 2024
View reviewed changes
@ShGKme ShGKme force-pushed the chore/nc-app-sidebar--do-not-use-nc-app-navigation-vars branch from 840c422 to 77b2f6f Compare July 25, 2024 07:47
@susnux susnux modified the milestones: 8.15.1, 8.15.2 Jul 29, 2024
@ShGKme ShGKme modified the milestones: 8.15.2, 8.16.0 Aug 3, 2024
@Antreesy Antreesy modified the milestones: 8.16.0, 8.17.0 Aug 5, 2024
@susnux susnux removed this from the 8.17.0 milestone Aug 21, 2024
@susnux susnux force-pushed the chore/nc-app-sidebar--do-not-use-nc-app-navigation-vars branch from 77b2f6f to 769f229 Compare July 9, 2025 19:50
@susnux susnux changed the base branch from stable8 to main July 9, 2025 19:50
@susnux susnux added feature: documentation Related to the documentation refactor ♻️ Pull request that is neither a fix nor a feature labels Jul 9, 2025
@susnux
Copy link
Contributor

susnux commented Jul 9, 2025

Rebased onto main

@susnux susnux requested review from hamza221 and removed request for Pytal July 9, 2025 19:53
@susnux susnux modified the milestones: 9.0.0-rc.4, 9.0.0-rc.5 Jul 9, 2025
ShGKme added 3 commits July 16, 2025 13:30
@ShGKme @susnux
refactor(NcAppNavigation): do not rely on $app-navigation-padding
5cefc90 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme @susnux
chore(NcAppSidebar): fix css vars doc
3bb3d0a 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme @susnux
docs(NcAppSidebar): add exposed CSS variables docs section
bc82d45 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@susnux susnux force-pushed the chore/nc-app-sidebar--do-not-use-nc-app-navigation-vars branch from 769f229 to bc82d45 Compare July 16, 2025 11:31
@susnux susnux merged commit 2e3eb71 into main Jul 16, 2025
25 checks passed
@susnux susnux deleted the chore/nc-app-sidebar--do-not-use-nc-app-navigation-vars branch July 16, 2025 11:35
@Antreesy Antreesy mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component feature: documentation Related to the documentation refactor ♻️ Pull request that is neither a fix nor a feature
Projects
None yet
Milestone
9.0.0-rc.5
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @susnux @Antreesy