fix(NcDashboardWidgetItem): alignment of item content #5914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
susnux
reviewed
Aug 5, 2024
| @@ -197,7 +197,7 @@ export default { | |||
| } | |||
| .item__details { | |||
| padding-left: 8px; | |||
| max-height: var(--default-clickable-area); | |||
| max-height: fit-content; | |||
There was a problem hiding this comment.
Yes this is a problem with the new default clickable area, it does not fit 2 lines (well it can but that is quite hacky see the NcSelect for users).
We should still define a maximum, maybe clickable-area-large?
Or unify with NcListItem?
There was a problem hiding this comment.
Yeah, standardizing in the list item sounds good, but won't have time to dive too deep into that. This was just a drive by pr while chatting with Andy hoping for a quick fix 🙈
susnux
approved these changes
Aug 5, 2024
AndyScherzinger
approved these changes
Aug 5, 2024
|
/backport to next |
susnux
added
bug
Merged
ShGKme
changed the title
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade