Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(NcColorPicker): adjust styles of advanced fields to match NcInputField #6097

Merged
merged 1 commit into from
Sep 17, 2024
Merged

style(NcColorPicker): adjust styles of advanced fields to match NcInputField #6097

merged 1 commit into from
Sep 17, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 16, 2024 •
edited
Loading

☑️ Resolves

  • Fix styling. Nothing more
  • Rules are mostly a copy-paste from NcInputFIeld

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
style(NcColorPicker): adjust styles of advanced fields to match NcInp…
e418a18 
…utField

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: colorpicker Related to the colorpicker component labels Sep 16, 2024
@Antreesy Antreesy added this to the 8.19.0 milestone Sep 16, 2024
@Antreesy Antreesy self-assigned this Sep 16, 2024
@ShGKme ShGKme added the bug Something isn't working label Sep 17, 2024
@Antreesy Antreesy mentioned this pull request Sep 17, 2024
Merged
@Antreesy Antreesy merged commit de93af6 into master Sep 17, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/noid/color-picker-styling branch September 17, 2024 08:48
@Antreesy
Copy link
Contributor Author

/backport to next

@backportbot backportbot bot mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: colorpicker Related to the colorpicker component
Projects
None yet
Milestone
8.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @mejo- @ShGKme