feat: Add rules for all annotations replaced by attributes in 27 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
commented
Feb 3, 2025
tests/Set/Nextcloud27/Fixture/controller_use_session_annotation.php.inc
Outdated
Show resolved
Hide resolved
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Collaborator
Author
|
Either we wait for a fix or write our own Rector based on AnnotationToAttribute. |
Contributor
|
And many other annotation/attribute pairs also work slightly different, so a custom solution is probably required. |
This fixes migration for most annotations to attribute. Commented out AuthorizedAdminSetting because it’s a more complex case. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/add-annotations-migrations
branch
from
de718b2 to
1dd2ef0
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Collaborator
Author
|
Let’s merge as-is and note AuthorizedAdminSetting as a todo for later? |
provokateurin
approved these changes
Mar 11, 2025
Contributor
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Not too knowledgable about the internals of rector, but the result looks great 👍
nickvergessen
approved these changes
Mar 31, 2025
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17
Description
Add rules in 27 set to migrate all annotations to attributes.
Types of changes
PR checklist